From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9wrT-0000pi-39 for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:13:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9wrN-00057n-37 for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:13:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9wrM-000578-Rm for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:13:17 -0500 Date: Sun, 2 Feb 2014 15:12:55 +0200 From: "Michael S. Tsirkin" Message-ID: <20140202131255.GB25713@redhat.com> References: <1389285399-28417-1-git-send-email-imammedo@redhat.com> <1389285399-28417-8-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389285399-28417-8-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 7/9] pc: ACPI: expose PRST IO range via _CRS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, chen.fan.fnst@cn.fujitsu.com, aliguori@amazon.com, anthony.perard@citrix.com, afaerber@suse.de On Thu, Jan 09, 2014 at 05:36:37PM +0100, Igor Mammedov wrote: > .. so OSPM could notice resource conflict if there is any. > > Signed-off-by: Igor Mammedov Hi Igor, I noticed an unpleasant side effect caused by this patch. Now, windows xp prompts me for a driver for this device every time I boot it. If I click cancel it goes away, but it's annoying. I think ACPI0004 is too new for winxp to recognize it. I tried the following patch and it seems to work fine. What do you think? diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl index dee4843..34aab5a 100644 --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl @@ -93,7 +93,7 @@ Scope(\_SB) { } Device(CPU_HOTPLUG_RESOURCE_DEVICE) { - Name(_HID, "ACPI0004") + Name(_HID, EisaId("PNP0A06")) Name(_CRS, ResourceTemplate() { IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN) > --- > v2: > * use define for DEVICE name to make it more descriptive > * define _STA as present,functioning, decoding, not shown in UI > --- > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 14 +++++++++++++- > 1 files changed, 13 insertions(+), 1 deletions(-) > > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > index 1dfbb4f..f91eafd 100644 > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > @@ -16,6 +16,7 @@ > /**************************************************************** > * CPU hotplug > ****************************************************************/ > +#define CPU_HOTPLUG_RESOURCE_DEVICE PRES > > Scope(\_SB) { > /* Objects filled in by run-time generated SSDT */ > @@ -52,7 +53,8 @@ Scope(\_SB) { > Sleep(200) > } > > - OperationRegion(PRST, SystemIO, CPU_STATUS_BASE, 32) > +#define CPU_STATUS_LEN 32 > + OperationRegion(PRST, SystemIO, CPU_STATUS_BASE, CPU_STATUS_LEN) > Field(PRST, ByteAcc, NoLock, Preserve) { > PRS, 256 > } > @@ -89,4 +91,14 @@ Scope(\_SB) { > Increment(Local0) > } > } > + > + Device(CPU_HOTPLUG_RESOURCE_DEVICE) { > + Name(_HID, "ACPI0004") > + > + Name(_CRS, ResourceTemplate() { > + IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN) > + }) > + > + Name(_STA, 0xB) /* present, functioning, decoding, not shown in UI */ > + } > } > -- > 1.7.1