From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WAGnQ-0001J7-Rz
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 05:30:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WAGnM-0005bD-QI
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 05:30:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41579)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WAGnM-0005b6-GA
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 05:30:28 -0500
Date: Mon, 3 Feb 2014 10:29:59 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20140203102959.GA10408@redhat.com>
References: <1391401575-52256-1-git-send-email-chrisj@rtems.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1391401575-52256-1-git-send-email-chrisj@rtems.org>
Subject: Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config
 check.
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chris Johns <chrisj@rtems.org>
Cc: qemu-devel@nongnu.org

On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote:
> Building against with a recent glib in a custom prefix fails because
> the gthread cflags in the pkg-config file do not have the correct path
> while the glib pc file does.
> 
> Signed-off-by: Chris Johns <chrisj@rtems.org>
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index b472694..12f730f 100755
> --- a/configure
> +++ b/configure
> @@ -2343,9 +2343,9 @@ if test "$mingw32" = yes; then
>  else
>      glib_req_ver=2.12
>  fi
> -if $pkg_config --atleast-version=$glib_req_ver gthread-2.0; then
> -    glib_cflags=`$pkg_config --cflags gthread-2.0`
> -    glib_libs=`$pkg_config --libs gthread-2.0`
> +if $pkg_config --atleast-version=$glib_req_ver glib-2.0; then
> +    glib_cflags=`$pkg_config --cflags glib-2.0`
> +    glib_libs=`$pkg_config --libs glib-2.0`
>      LIBS="$glib_libs $LIBS"
>      libs_qga="$glib_libs $libs_qga"
>  else

This change will cause  -pthread linker + compiler flag to be lost.


What glib version are you seeing a problem with ? It seems we should
really fix glib, since this will affect countless 1000's of apps using
it, not try to workaround in all downstream apps.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|