From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAJyS-0007vf-7G for qemu-devel@nongnu.org; Mon, 03 Feb 2014 08:54:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAJyL-00031k-NQ for qemu-devel@nongnu.org; Mon, 03 Feb 2014 08:54:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAJyL-00031e-FR for qemu-devel@nongnu.org; Mon, 03 Feb 2014 08:54:01 -0500 Date: Mon, 3 Feb 2014 15:58:58 +0200 From: "Michael S. Tsirkin" Message-ID: <20140203135858.GB24520@redhat.com> References: <1391424301-22703-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391424301-22703-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/5] pc: make ACPI pcihp more reusable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, aliguori@amazon.com On Mon, Feb 03, 2014 at 11:44:56AM +0100, Igor Mammedov wrote: > changes since v3: > - keep "acpi-pci-hotplug-with-bridge-support" property > and pass its value to acpi_pcihp_init() to init internal > .legacy_piix field. > changes since v2: > - rename 'use_acpi_pci_hotplug' field to 'legacy_piix' > and corresponding properties > - drop excessive checks for legacy mode > - rework legacy vmstate handling to use AcpiPciHpPciStatus[0] structure > which reduced acpi/piix4.c by another 50 LOC > - move legacy initialization to pcihp.c > changes since v1: > - add BSEL property to root bus when in compatibility mode > as result dropped "hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property" > - rebasing on top of "pcihp: reduce number of device check events" > added patch 3/4. Looks good to me. Applied, thanks a lot. > Reuses new pcihp code for handling legacy PCI hotplug in > acpi/piix4_pm, which significantly reduces code duplication > between piix4_pm and pcihp reducing codebase by ~200 LOC. > > It also allows cleaner rebase of generic hotplug refactoring, > by not increasing code duplication since it will need to be > done only for pcihp. > > Git tree for testing based on mst's PCI tree: > https://github.com/imammedo/qemu/commits/pcihp_cleanup_v4 > > > > Igor Mammedov (5): > pcihp: replace enable|disable_device() with oneliners > pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR > pcihp: make pci_read() mmio calback compatible with legacy ACPI > hotplug > pcihp: remove unused AcpiPciHpPciStatus.device_present field > hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug > > hw/acpi/pcihp.c | 68 ++++++++------- > hw/acpi/piix4.c | 210 ++++------------------------------------------- > include/hw/acpi/pcihp.h | 5 +- > 3 files changed, 55 insertions(+), 228 deletions(-)