From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Fail gracefully with missing filename
Date: Mon, 3 Feb 2014 16:16:35 +0100 [thread overview]
Message-ID: <20140203151634.GC17247@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1391435731-25948-1-git-send-email-kwolf@redhat.com>
On Mon, Feb 03, 2014 at 02:55:31PM +0100, Kevin Wolf wrote:
> This fixes a regression introduced in commit 2a05cbe42 ('block: Allow
> block devices without files'):
>
> $ qemu-system-x86_64 -drive driver=file
> qemu-system-x86_64: block.c:892: bdrv_open_common: Assertion
> `!drv->bdrv_needs_filename || filename != ((void *)0)' failed.
>
> Now the respective check must be performed not only in bdrv_file_open(),
> but also in bdrv_open().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 11 ++++++-----
> tests/qemu-iotests/051 | 12 ++++++++++++
> tests/qemu-iotests/051.out | 24 ++++++++++++++++++++++++
> 3 files changed, 42 insertions(+), 5 deletions(-)
Ouch! Nice to have tests that protect us in the future.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2014-02-03 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 13:55 [Qemu-devel] [PATCH] block: Fail gracefully with missing filename Kevin Wolf
2014-02-03 15:16 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203151634.GC17247@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).