From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39993)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WALuT-0002Bw-HG
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:58:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WALuO-0002Cd-Tw
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:58:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30713)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WALuO-0002CR-Ky
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:58:04 -0500
Date: Mon, 3 Feb 2014 16:57:56 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140203155756.GP3643@dhcp-200-207.str.redhat.com>
References: <1390997015-19609-1-git-send-email-pl@kamp.de>
	<20140129153606.GD3079@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140129153606.GD3079@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: always fill
	bs->bl.opt_transfer_length
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: ronniesahlberg@gmail.com, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, stefanha@redhat.com

Am 29.01.2014 um 16:36 hat Beno=EEt Canet geschrieben:
> Le Wednesday 29 Jan 2014 =E0 13:03:35 (+0100), Peter Lieven a =E9crit :
> > the opt_transfer_length has nothing to do with logical
> > block provisioning stuff so always copy it from
> > the block limits VPD page.
> >=20
> > Reported-By: Benoit Canet <benoit@irqsave.net>
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> >  block/iscsi.c |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/block/iscsi.c b/block/iscsi.c
> > index 38b07f8..3c0b728 100644
> > --- a/block/iscsi.c
> > +++ b/block/iscsi.c
> > @@ -1331,10 +1331,9 @@ static int iscsi_refresh_limits(BlockDriverSta=
te *bs)
> >          }
> >          bs->bl.write_zeroes_alignment =3D sector_lun2qemu(iscsilun->=
bl.opt_unmap_gran,
> >                                                          iscsilun);
> > -
> > -        bs->bl.opt_transfer_length =3D sector_lun2qemu(iscsilun->bl.=
opt_xfer_len,
> > -                                                     iscsilun);
> >      }
> > +    bs->bl.opt_transfer_length =3D sector_lun2qemu(iscsilun->bl.opt_=
xfer_len,
> > +                                                 iscsilun);
> >      return 0;
> >  }
> > =20
> > --=20
> > 1.7.9.5
> >=20
> Reviewed-by: Benoit Canet <benoit@irqsave.net>

Thanks, applied to the block branch.

Kevin