From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WAQLk-0003lw-L2
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:42:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WAQLf-0003Bj-OQ
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:42:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37396)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WAQLf-0003Bd-FO
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:42:31 -0500
Date: Mon, 3 Feb 2014 21:42:18 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140203214218.68f79693@thinkpad>
In-Reply-To: <52EFF016.7050102@redhat.com>
References: <1391443030-8662-1-git-send-email-imammedo@redhat.com>
	<52EFF016.7050102@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/9] Refactor PCI/SHPC/PCIE hotplug to
 use a more generic hotplug API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, aliguori@amazon.com, mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de

On Mon, 03 Feb 2014 12:37:58 -0700
Eric Blake <eblake@redhat.com> wrote:

> On 02/03/2014 08:57 AM, Igor Mammedov wrote:
> > changes since v4:
> >  - rebased on top of PCI tree
> >  - added wrapper to set hotplug-device property
> > 
> 
> I don't consider myself qualified to review this one on technical
> merits, but I did spot a number of typos and other minor improvements.

Thanks for looking at it,
I'll fix spelling errors/typos and resubmit series.


> 
> > 
> > Igor Mammedov (9):
> >   define hotplug interface
> >   qdev: add to BusState "hotplug-handler" link
> >   qdev: add "hotpluggable" property to Device
> >   hw/acpi: move typeinfo to the file end
> >   qdev:pci: refactor PCIDevice to use generic "hotpluggable" property
> >   acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API
> >   pci/shpc: convert SHPC hotplug to use hotplug-handler API
> >   pci/pcie: convert PCIE hotplug to use hotplug-handler API
> >   hw/pci: switch to a generic hotplug handling for PCIDevice
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


-- 
Regards,
  Igor