From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WARmq-0007Cp-LL for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:14:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WARmk-0006Ml-LR for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:14:40 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:49108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WARmk-0006Md-Am for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:14:34 -0500 Date: Mon, 3 Feb 2014 23:14:32 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140203221432.GA25860@irqsave.net> References: <1391454712-14353-1-git-send-email-benoit.canet@irqsave.net> <20140203211000.GA28264@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140203211000.GA28264@localhost.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Le Monday 03 Feb 2014 =E0 16:10:00 (-0500), Jeff Cody a =E9crit : > On Mon, Feb 03, 2014 at 08:11:39PM +0100, Beno=EEt Canet wrote: > > v14: > > Use quorum_report_failure in early failure test suggested by Max [= Beno=EEt] > >=20 > > v13: > > update copyright date and company legal status > >=20 > > Beno=EEt Canet (13): > > quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. > > quorum: Create BDRVQuorumState and BlkDriver and do init. > > quorum: Add quorum_aio_writev and its dependencies. > > blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from > > blkverify. > > quorum: Add quorum_aio_readv. > > quorum: Add quorum mechanism. > > quorum: Add quorum_getlength(). > > quorum: Add quorum_invalidate_cache(). > > quorum: Add quorum_co_get_block_status. > > quorum: Add quorum_co_flush(). > > quorum: Implement recursive .bdrv_recurse_is_first_non_filter in > > quorum. > > quorum: Add quorum_open() and quorum_close(). > > quorum: Add unit test. > > >=20 > Most of the patches in this series are lacking meaningful commit > messages - via this series, quorum.c is created, with not much more > than 1-line commit logs. Could you please add more details to the > commit messages? Ok, I'll do a v16 tomorow. Best regards Beno=EEt >=20 > Thanks, > Jeff >=20 >=20 > > block/Makefile.objs | 1 + > > block/blkverify.c | 108 +----- > > block/quorum.c | 915 +++++++++++++++++++++++++++++++++++= ++++++++++ > > configure | 36 ++ > > docs/qmp/qmp-events.txt | 33 ++ > > include/monitor/monitor.h | 2 + > > include/qemu-common.h | 2 + > > monitor.c | 2 + > > qapi-schema.json | 21 +- > > tests/qemu-iotests/075 | 95 +++++ > > tests/qemu-iotests/075.out | 34 ++ > > tests/qemu-iotests/group | 1 + > > util/iov.c | 103 +++++ > > 13 files changed, 1246 insertions(+), 107 deletions(-) > > create mode 100644 block/quorum.c > > create mode 100755 tests/qemu-iotests/075 > > create mode 100644 tests/qemu-iotests/075.out > >=20 > > --=20 > > 1.8.3.2 > >=20 > >=20 >=20