From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAbba-0001SL-Ie for qemu-devel@nongnu.org; Tue, 04 Feb 2014 03:43:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAbbV-0001vr-Lx for qemu-devel@nongnu.org; Tue, 04 Feb 2014 03:43:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAbbV-0001vm-Do for qemu-devel@nongnu.org; Tue, 04 Feb 2014 03:43:37 -0500 Date: Tue, 4 Feb 2014 09:43:24 +0100 From: Igor Mammedov Message-ID: <20140204094324.61790520@thinkpad> In-Reply-To: <52F000FA.9060408@redhat.com> References: <1391443030-8662-1-git-send-email-imammedo@redhat.com> <1391443030-8662-3-git-send-email-imammedo@redhat.com> <52EFEE3C.10608@redhat.com> <20140203213828.38f1fac6@thinkpad> <52F000FA.9060408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, stefanha@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de On Mon, 03 Feb 2014 13:50:02 -0700 Eric Blake wrote: > On 02/03/2014 01:38 PM, Igor Mammedov wrote: > > >>> +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState *handler, > >>> + Error **errp) > >>> +{ > >>> + object_property_set_link(OBJECT(bus), OBJECT(handler), > >>> + QDEV_HOTPLUG_HANDLER_PROPERTY, errp); > >>> + bus->allow_hotplug = 1; > >> > >> Should we convert allow_hotplug to bool over the course of this series? > > There isn't much point in touching it, since it's going to be removed once > > all hotplug-able buses are converted to new interface. > > After finishing my read through your series, I noticed that you were > using allow_hotplug less and less and instead using a new bool in most > code you added. Does that just mean your series didn't touch every last > client of the old interface, and that there still remains code to be > converted, where this series serves as the example of how? Yes, beside adding new hotplug mechanism, it converts only PCI hotplug workflow as example. Paolo had plans to convert scsi hotplug once this series is in. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Regards, Igor