From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAgzL-0008PJ-MK for qemu-devel@nongnu.org; Tue, 04 Feb 2014 09:28:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAgzF-0000qa-MH for qemu-devel@nongnu.org; Tue, 04 Feb 2014 09:28:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAgzF-0000nP-Dr for qemu-devel@nongnu.org; Tue, 04 Feb 2014 09:28:29 -0500 Date: Tue, 4 Feb 2014 16:32:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20140204143219.GA7561@redhat.com> References: <1265435524.20140204004608@eikelenboom.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1265435524.20140204004608@eikelenboom.it> Subject: Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sander Eikelenboom Cc: Anthony PERARD , xen-devel , "qemu-devel@nongnu.org" , Stefano Stabellini On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: > Grmbll my fat fingers hit the send shortcut too soon by accident .. > let's try again .. > > Hi Michael, > > A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 breaks pci-passthrough on Xen. > > commit 9e047b982452c633882b486682966c1d97097015 > Author: Michael S. Tsirkin > Date: Mon Oct 14 18:01:20 2013 +0300 > > piix4: add acpi pci hotplug support > > Add support for acpi pci hotplug using the > new infrastructure. > PIIX4 legacy interface is maintained as is for > machine types 1.7 and older. > > Signed-off-by: Michael S. Tsirkin > > > The error is not very verbose : > > libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed. > libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed. > libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed. > libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed. > > So it seems there is an issue with preserving the legacy interface. Which machine type is broken? What's the command line used? What's the value of has_acpi_build in hw/i386/pc_piix.c? What happens if you add -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off ? > -- > Sander >