From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAkr6-0005Ny-JX for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:36:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAkr5-0001Z9-Nw for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:36:20 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::10]:40641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAjDY-0000S8-FM for qemu-devel@nongnu.org; Tue, 04 Feb 2014 11:51:24 -0500 Date: Tue, 4 Feb 2014 17:51:15 +0100 From: Olaf Hering Message-ID: <20140204165115.GA27169@aepfle.de> References: <1391094138-26798-1-git-send-email-olaf@aepfle.de> <20140203154908.GO3643@dhcp-200-207.str.redhat.com> <20140204154737.GA19903@aepfle.de> <20140204161523.GQ3384@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140204161523.GQ3384@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH] xen_disk: add discard support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, stefano.stabellini@eu.citrix.com On Tue, Feb 04, Kevin Wolf wrote: > Now you call bdrv_acct_done() in the callback without having a matching > bdrv_acct_start(). You need to make it conditional in the callback. I see. Stefano, Is ioreq_runio_qemu_aio symetric in this regard anyway? In case of BLKIF_OP_WRITE|BLKIF_OP_FLUSH_DISKCACHE and no ioreq->req.nr_segments then qemu_aio_complete is called anyway. Will qemu_aio_complete get down to the bdrv_acct_done call at all in this case? Olaf