From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45062)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WAka9-0001K1-57
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:18:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WAka3-0001T1-7D
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:18:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WAjsx-0003Ar-CU
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 12:34:11 -0500
Date: Tue, 4 Feb 2014 17:34:05 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20140204173404.GE2733@work-vm>
References: <1391527185-28349-1-git-send-email-quintela@redhat.com>
	<1391527185-28349-8-git-send-email-quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1391527185-28349-8-git-send-email-quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>, qemu-devel@nongnu.org, anthony@codemonkey.ws

* Juan Quintela (quintela@redhat.com) wrote:
> From: Orit Wasserman <owasserm@redhat.com>

>      if (!it->it_data) {
>          cache->num_items++;
> +        it->it_data = g_try_malloc(cache->page_size);
> +        if (!it->it_data) {
> +            DPRINTF("Error allocating page\n");
> +            return -1;
> +        }

Hmm that wasn't the latest version of that patch (or the previous
one in the series).

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK