From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WAkKy-0001B8-DD
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:03:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WAkKP-0004I7-AI
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:02:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:25654)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WAkKP-0004Ho-1P
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:02:33 -0500
Date: Tue, 4 Feb 2014 20:07:24 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140204180724.GA11013@redhat.com>
References: <1387904675-7962-1-git-send-email-afaerber@suse.de>
	<52F10DC5.3040103@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <52F10DC5.3040103@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, xiaoqiang zhao <zxq_yx_007@163.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, =?iso-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas F=E4rber wrote:
> Michael,
>=20
> Am 24.12.2013 18:04, schrieb Andreas F=E4rber:
> > P.S. I reproducibly get a signal message:
> > TEST: tests/acpi-test... (pid=3D6364)
> >   /i386/acpi/tcg:                                                    =
  main-loop: WARNING: I/O thread spun for 1000 iterations
> > qemu: terminating on signal 15 from pid 6364
> > OK
> > PASS: tests/acpi-test
> > both before and after the queue.
>=20
> I'm still seeing this during make check - are you aware? Is there a fix=
?
>=20
> Regards,
> Andreas
>=20
> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg


so the bug seems to be in the reporting:

static void qemu_kill_report(void)
{
    if (!qtest_enabled() && shutdown_signal !=3D -1) {
        fprintf(stderr, "qemu: terminating on signal %d",
shutdown_signal);
        if (shutdown_pid =3D=3D 0) {
            /* This happens for eg ^C at the terminal, so it's worth
             * avoiding printing an odd message in that case.
             */
            fputc('\n', stderr);
        } else {
            fprintf(stderr, " from pid " FMT_pid "\n", shutdown_pid);
        }
        shutdown_signal =3D -1;
    }
}

it shouldn't print this under qtest driver, instead it checks
accelerator value which is wrong.

I just sent a patch, please try it.