qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled
Date: Wed, 5 Feb 2014 17:15:47 +0200	[thread overview]
Message-ID: <20140205151547.GB6915@redhat.com> (raw)
In-Reply-To: <52F25353.402@suse.de>

On Wed, Feb 05, 2014 at 04:05:55PM +0100, Andreas Färber wrote:
> Am 04.02.2014 19:06, schrieb Michael S. Tsirkin:
> > qtest driver always uses signals to kill qemu
> > no need to report it, whatever the accelerator state.
> > 
> > Add API to detect qtest driver, and suppress reporting
> > signals in this case.
> > 
> > Reported-by: Andreas Färber <afaerber@suse.de>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Tested-by: Andreas Färber <afaerber@suse.de>
> 
> We could do some bikeshedding about better names for qtest_driver(), but
> I'm happy to learn that it was just noise and not a real issue.
> 
> I'll queue a copy for my qom-test work, but through whose queue should
> this best go? PMM directly?
> 
> Thanks,
> Andreas

It affects acpi tests so for now I have it on my queue.

> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2014-02-05 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 18:06 [Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled Michael S. Tsirkin
2014-02-05 15:05 ` Andreas Färber
2014-02-05 15:15   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205151547.GB6915@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).