From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WB3tz-000297-Sb
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 09:56:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WB3tv-0002j3-4w
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 09:56:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48262)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WB3tu-0002iV-Sc
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 09:56:31 -0500
Date: Wed, 5 Feb 2014 15:56:23 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140205155623.772a6c35@thinkpad>
In-Reply-To: <1391610653-13439-1-git-send-email-afaerber@suse.de>
References: <1391610653-13439-1-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] nand: Don't use qdev_create() in
 nand_init()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, peter.maydell@linaro.org, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed,  5 Feb 2014 15:30:53 +0100
Andreas F=E4rber <afaerber@suse.de> wrote:

> Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit
> from Sysbus) changed the parent type of TYPE_NAND but continued to use
> qdev_create(), which handled a NULL BusState as SysBus.
>=20
> Use object_new() instead, and reuse the TYPE_NAND define while at it.
>=20
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
> ---
>  hw/block/nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/hw/block/nand.c b/hw/block/nand.c
> index a871ce0..6d7c804 100644
> --- a/hw/block/nand.c
> +++ b/hw/block/nand.c
> @@ -632,7 +632,7 @@ DeviceState *nand_init(BlockDriverState *bdrv, int ma=
nf_id, int chip_id)
>      if (nand_flash_ids[chip_id].size =3D=3D 0) {
>          hw_error("%s: Unsupported NAND chip ID.\n", __FUNCTION__);
>      }
> -    dev =3D qdev_create(NULL, "nand");
> +    dev =3D DEVICE(object_new(TYPE_NAND));
>      qdev_prop_set_uint8(dev, "manufacturer_id", manf_id);
>      qdev_prop_set_uint8(dev, "chip_id", chip_id);
>      if (bdrv) {
> --=20
> 1.8.4.5
>=20
>

Reviewed-By: Igor Mammedov <imammedo@redhat.com>

--=20
Regards,
  Igor