From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5iC-00067p-HI for qemu-devel@nongnu.org; Wed, 05 Feb 2014 11:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB5i7-0000tm-D6 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 11:52:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5i7-0000te-3D for qemu-devel@nongnu.org; Wed, 05 Feb 2014 11:52:27 -0500 Date: Wed, 5 Feb 2014 17:52:16 +0100 From: Igor Mammedov Message-ID: <20140205175216.3e011738@thinkpad> In-Reply-To: <52F26363.2050607@suse.de> References: <1385591336-2755-1-git-send-email-imammedo@redhat.com> <52AE3247.5000303@suse.de> <20140205154007.4886f3e3@thinkpad> <52F26363.2050607@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: Eduardo Habkost , armbru@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , pbonzini@redhat.com, akong@redhat.com On Wed, 05 Feb 2014 17:14:27 +0100 Andreas F=E4rber wrote: > Am 05.02.2014 15:40, schrieb Igor Mammedov: > > On Sun, 15 Dec 2013 23:50:47 +0100 > > Andreas F=E4rber wrote: > >=20 > >> Am 27.11.2013 23:28, schrieb Igor Mammedov: > >>> Igor Mammedov (16): > >>> target-i386: cleanup 'foo' feature handling' > >>> target-i386: cleanup 'foo=3Dval' feature handling > >> > >> Thanks, I've queued these on qom-cpu-next: > >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next > >> > >>> target-i386: cpu: convert 'level' to static property > >>> target-i386: cpu: convert 'xlevel' to static property > >>> target-i386: cpu: convert 'family' to static property > >>> target-i386: cpu: convert 'model' to static property > >>> target-i386: cpu: convert 'stepping' to static property > >>> target-i386: cpu: convert 'vendor' to static property > >>> target-i386: cpu: convert 'model-id' to static property > >>> target-i386: cpu: convert 'tsc-frequency' to static property > >> > >> But I still don't see the utility of this conversion after all the > >> discussions we've had... :( > > It seems there is movement to make DEVICE self describing for purpose > > of QAPI schema introspection, where static properties would be used > > (dynamic ones are not suitable for this purpose) >=20 > Do you have a pointer to such a discussion? Sounds like I was not > involved and Anthony probably not either... Not at the moment, CCing people who might know more about the topic. But just thinking about creating QAPI schema for devices, it's not really possible to generate one using dynamic properties (unless one resorts to creating every supported device instance), while arrays of static properties are there for every device and simplistically speaking just need conversion to schema format. >=20 > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg --=20 Regards, Igor