From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest
Date: Fri, 7 Feb 2014 16:48:57 +0100 [thread overview]
Message-ID: <20140207154857.GC25412@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1391619677-32387-2-git-send-email-afaerber@suse.de>
On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote:
> +#include "libqtest.h"
> +
> +#include <glib.h>
> +#include <string.h>
> +#include "qemu/osdep.h"
Please put <system.h> includes before "user.h" includes. That way we
can be sure our macros don't mess up system headers.
> +
> +static void nop(void)
> +{
> +}
I suggest a comment here to explain the point of this test:
/* The point of this test case is just to instantiate the device */
next prev parent reply other threads:[~2014-02-07 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 17:01 [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest Andreas Färber
2014-02-07 15:48 ` Stefan Hajnoczi [this message]
2014-02-07 18:06 ` Andreas Färber
2014-02-08 10:23 ` Stefan Hajnoczi
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 2/5] tests: Add vmxnet3 qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 3/5] tests: Add rtl8139 qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 4/5] tests: Add PC-Net qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 5/5] tests: Add eepro100 qtest Andreas Färber
2014-02-07 15:50 ` [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207154857.GC25412@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).