qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests
Date: Fri, 7 Feb 2014 16:50:31 +0100	[thread overview]
Message-ID: <20140207155031.GD25412@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1391619677-32387-1-git-send-email-afaerber@suse.de>

On Wed, Feb 05, 2014 at 06:01:12PM +0100, Andreas Färber wrote:
> Hello Stefan,
> 
> As discussed late last year, this series starts preparing tests to cover
> optional NICs. They don't do any functional tests but assure that QOM/PCI
> refactorings don't break the basic usage of these devices.
> 
> pcnet-test.c is intended to handle sparc's lance as well.
> 
> virtio-net is missing among others (is there any ongoing work on virtio
> qtests?!), but I thought I'd get this out as a start. My goal will be to
> have every optional device in 2.0 covered by such basic tests.
> Hopefully it will also encourage people to write functional tests later on
> and to copy these stubs for new devices!
> 
> Regards,
> Andreas
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Anthony Liguori <anthony@codemonkey.ws>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> 
> Andreas Färber (5):
>   tests: Add e1000 qtest
>   tests: Add vmxnet3 qtest
>   tests: Add rtl8139 qtest
>   tests: Add PC-Net qtest
>   tests: Add eepro100 qtest
> 
>  tests/Makefile        | 22 +++++++++++++++++++
>  tests/e1000-test.c    | 35 +++++++++++++++++++++++++++++
>  tests/eepro100-test.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/pcnet-test.c    | 35 +++++++++++++++++++++++++++++
>  tests/rtl8139-test.c  | 35 +++++++++++++++++++++++++++++
>  tests/vmxnet3-test.c  | 35 +++++++++++++++++++++++++++++
>  6 files changed, 223 insertions(+)
>  create mode 100644 tests/e1000-test.c
>  create mode 100644 tests/eepro100-test.c
>  create mode 100644 tests/pcnet-test.c
>  create mode 100644 tests/rtl8139-test.c
>  create mode 100644 tests/vmxnet3-test.c

Not much going on here, should be easy to merge.  I did leave comments
on the first patch, they apply to all other patches in the series as
well.

      parent reply	other threads:[~2014-02-07 15:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 17:01 [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest Andreas Färber
2014-02-07 15:48   ` Stefan Hajnoczi
2014-02-07 18:06     ` Andreas Färber
2014-02-08 10:23       ` Stefan Hajnoczi
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 2/5] tests: Add vmxnet3 qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 3/5] tests: Add rtl8139 qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 4/5] tests: Add PC-Net qtest Andreas Färber
2014-02-05 17:01 ` [Qemu-devel] [PATCH qom-next 5/5] tests: Add eepro100 qtest Andreas Färber
2014-02-07 15:50 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207155031.GD25412@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).