From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBtF5-00047A-5o for qemu-devel@nongnu.org; Fri, 07 Feb 2014 16:45:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBtEz-0004IH-5S for qemu-devel@nongnu.org; Fri, 07 Feb 2014 16:45:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBtEy-0004ID-Sy for qemu-devel@nongnu.org; Fri, 07 Feb 2014 16:45:41 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17LjdiC011423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Feb 2014 16:45:40 -0500 Date: Fri, 7 Feb 2014 22:45:37 +0100 From: Kevin Wolf Message-ID: <20140207214537.GA3099@dhcp-200-207.str.redhat.com> References: <1391789578-19601-1-git-send-email-kwolf@redhat.com> <1391789578-19601-4-git-send-email-kwolf@redhat.com> <52F50987.7030406@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <52F50987.7030406@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lersek@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: > On 02/07/2014 09:12 AM, Kevin Wolf wrote: > > The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > > It happens to do the right thing in this please, but better avoid it. >=20 > s/please/place/ Indeed... Thanks, fixed it locally. > > Suggested-by: Laszlo Ersek > > Signed-off-by: Kevin Wolf > > --- > > block.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > Series: Reviewed-by: Eric Blake Kevin --KsGdsel6WgEHnImy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJS9VQBAAoJEH8JsnLIjy/Wy1sQAKJ5U1oj18tsxCsFohzMCtRE BaTK1touHJa9DBoFmi9I/Qp0tq4ryPca6Uh71U+VHqhCztkvXxySMIDZEjgSb2IT 5ad9qj+MCBQx2gBTrNe1ODbROflcRZ3FYNkKkVcE/NqKTAF+xiY2QpqIERveOeV7 /HXo1ddYJw37MwpRpEf7aVGrSS1FPBr7zdbBbX95E6izVj9dkCWrYC9f4sosTwS0 jvXSYLEpznRDkpSRcB/vAWVutsJ8Us2vOHDU6ODfWqn2TMqV0eovkvoT0APUa2WE 6ktxNGU6gdwxMukWmALqqQcJI9SX9S9hZhyCNQmV1TxxhB5niG2Eov7GsXq8hWR7 J+iKMtt7pvflKI5c9pYT9dQpVBrLYZfoZR5fpOXfcY3wOaRqtg9BapA+NKUqRhNl YrgeLdn/IHS/OGmPyHwaZJdVQ9YYLAbwwXiMeLOiLoZavBrOstLn9oBXDc4rWOYD apv0nj8mVS1RvzZ0uK8+YfhtE9ih8hSKHUFji61QP1LgjYK31g/NVTzS7iPGvOMf SpRuvKRJ6/qhXn2TjZr75H9xhhd9lymrxWaQF75noMc9IkMn853JhY0UXAJ5Zh9d Eklqp7ZUQzUQLKNbK6rUrODK5NyMWOnCHW47ZW7DKRLa27TTiElQEx2m7aqcHmLa tKuATCEcW+jsEbDUN0tT =sLha -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--