From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WC367-0006iJ-Rw
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 03:17:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WC361-00022R-Rz
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 03:17:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WC361-00022N-K5
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 03:17:05 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s188H4SZ005225
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sat, 8 Feb 2014 03:17:04 -0500
Date: Sat, 8 Feb 2014 09:17:02 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140208081702.GA2954@dhcp-200-207.str.redhat.com>
References: <1391789578-19601-1-git-send-email-kwolf@redhat.com>
	<1391789578-19601-4-git-send-email-kwolf@redhat.com>
	<52F50987.7030406@redhat.com>
	<20140207214537.GA3099@dhcp-200-207.str.redhat.com>
	<52F56B28.3030600@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52F56B28.3030600@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with
 negative values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 08.02.2014 um 00:24 hat Laszlo Ersek geschrieben:
> On 02/07/14 22:45, Kevin Wolf wrote:
> > Am 07.02.2014 um 17:27 hat Eric Blake geschrieben:
> >> On 02/07/2014 09:12 AM, Kevin Wolf wrote:
> >>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
> >>> It happens to do the right thing in this please, but better avoid it.
> >>
> >> s/please/place/
> > 
> > Indeed... Thanks, fixed it locally.
> > 
> >>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> >>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >>> ---
> >>>  block.c | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> Series: Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Not necessary after Eric's review, but here it is anyway:
> 
> series
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Review is never unnecessary. Thanks, Laszlo.

Kevin