From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WC5MS-0007p5-KR
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 05:42:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WC5MM-0006x6-Lc
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 05:42:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55489)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WC5MM-0006x2-Dp
	for qemu-devel@nongnu.org; Sat, 08 Feb 2014 05:42:06 -0500
Date: Sat, 8 Feb 2014 11:23:59 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140208102359.GA3297@stefanha-thinkpad.redhat.com>
References: <1391619677-32387-1-git-send-email-afaerber@suse.de>
	<1391619677-32387-2-git-send-email-afaerber@suse.de>
	<20140207154857.GC25412@stefanha-thinkpad.redhat.com>
	<52F520C2.3030908@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <52F520C2.3030908@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On Fri, Feb 07, 2014 at 07:06:58PM +0100, Andreas F=E4rber wrote:
> Am 07.02.2014 16:48, schrieb Stefan Hajnoczi:
> > On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas F=E4rber wrote:
> >> +#include "libqtest.h"
> >> +
> >> +#include <glib.h>
> >> +#include <string.h>
> >> +#include "qemu/osdep.h"
> >=20
> > Please put <system.h> includes before "user.h" includes.  That way we
> > can be sure our macros don't mess up system headers.
>=20
> You are right in this case, but to my defense I copied this from anothe=
r
> file. ;) You'll find the "libqtest.h"-first pattern in:
>=20
> endianness-test.c
> fw_cfg-test.c
> i440fx-test.c
> m48t59-test.c
> qom-test.c
> rtc-test.c
> tmp105-test.c
>=20
> To make it clearer which example to copy from, feel free to submit a
> patch cleaning those up.

Okay, I will.  Thanks!

Stefan