From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCS51-0004zE-S0 for qemu-devel@nongnu.org; Sun, 09 Feb 2014 05:57:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCS4x-0007Nr-Ov for qemu-devel@nongnu.org; Sun, 09 Feb 2014 05:57:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCS4x-0007Nk-HC for qemu-devel@nongnu.org; Sun, 09 Feb 2014 05:57:39 -0500 Date: Sun, 9 Feb 2014 11:57:30 +0100 From: Igor Mammedov Message-ID: <20140209115730.7d43c777@thinkpad> In-Reply-To: <52F63E05.409@suse.de> References: <1391853717-3837-1-git-send-email-pbonzini@redhat.com> <52F63E05.409@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , Peter Maydell On Sat, 08 Feb 2014 15:24:05 +0100 Andreas F=E4rber wrote: > Paolo, >=20 > Am 08.02.2014 11:01, schrieb Paolo Bonzini: > > Anthony, Peter, > >=20 > > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49= 818f: > >=20 > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-= 01-24 15:52:44 -0800) > >=20 > > are available in the git repository at: > >=20 > > git://github.com/bonzini/qemu.git qdev-props > >=20 > > for you to fetch changes up to 94fb9add077db8a8f0be3796f44785694c4686bb: > >=20 > > qapi: refine human printing of sizes (2014-02-08 10:44:41 +0100) > >=20 > > ---------------------------------------------------------------- > > Paolo Bonzini (14): > > qapi: add size parser to StringInputVisitor > > qdev: sizes are now parsed by StringInputVisitor > > qdev: remove legacy parsers for hex8/32/64 > > qdev: legacy properties are now read-only > > qdev: legacy properties are just strings > > qdev: inline qdev_prop_parse > > qapi: add human mode to StringOutputVisitor > > qdev: use human mode in "info qtree" > > qdev: remove most legacy printers > > qdev: remove hex8/32/64 property types > > block: handle "rechs" and "large" translation options > > qdev: add enum property types to QAPI schema > > qdev: use QAPI type names for properties > > qapi: refine human printing of sizes >=20 > I had specifically requested to review and take these through qom-next, > like most qdev changes have gone lately. Why are you sending a pull > nontheless? In particular Luiz has not yet replied to the QERR issue I > pointed out. Patches with QERR_ are still accepted where it makes sense and user interfa= ce expects particular error type/message. In this particular context QERR_INVALID_PARAMETER_TYPE is appropriate since user interface expects this particular error in this context. Luiz wasn't objecting to this specific error case in past: http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00738.html if one greps for QERR_INVALID_PARAMETER_TYPE, visitors are using it extensi= vely and even qom/object.c uses it. > Apart from that issue all patches look okay on brief skimming over. >=20 > Patch 10 should've been slightly more verbose because changing the type > of properties is normally NOT allowed. The reason it is possible here is > because they are format-compatible, which the commit message does not > explain. >=20 > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg >=20 --=20 Regards, Igor