From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WCmlP-000703-RO
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:02:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WCmlL-0005px-0M
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:02:51 -0500
Date: Mon, 10 Feb 2014 11:07:44 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140210090744.GA16066@redhat.com>
References: <20140207153039.GZ29329@ERROL.INI.CMU.EDU>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140207153039.GZ29329@ERROL.INI.CMU.EDU>
Subject: Re: [Qemu-devel] [PATCH] ACPI: Remove commented-out code from
	HPET._CRS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: qemu-trivial@nongnu.org, imammedo@redhat.com, qemu-devel@nongnu.org

On Fri, Feb 07, 2014 at 10:30:40AM -0500, Gabriel L. Somlo wrote:
> IRQNoFlags on HPET._CRS crashes WinXP because it causes the HPET
> to conflict with the system timer and/or the RTC. It only occurs
> on Apple hardware, and even there it is exposed fully only when
> OS X is detected (via _OSI). Recent OS X versions work on QEMU
> without this statement, so at this time there is no need to find
> a better way to conditionally include the statement. This patch
> removes the commented out (and wrong, should have been {0, 8})
> statement from HPET._CRS.
> 
> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>

Applied, thanks!

> ---
>  hw/i386/acpi-dsdt-hpet.dsl | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/i386/acpi-dsdt-hpet.dsl b/hw/i386/acpi-dsdt-hpet.dsl
> index dfde174..44961b8 100644
> --- a/hw/i386/acpi-dsdt-hpet.dsl
> +++ b/hw/i386/acpi-dsdt-hpet.dsl
> @@ -39,9 +39,6 @@ Scope(\_SB) {
>              Return (0x0F)
>          }
>          Name(_CRS, ResourceTemplate() {
> -#if 0       /* This makes WinXP BSOD for not yet figured reasons. */
> -            IRQNoFlags() {2, 8}
> -#endif
>              Memory32Fixed(ReadOnly,
>                  0xFED00000,         // Address Base
>                  0x00000400,         // Address Length
> -- 
> 1.8.1.4