From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCniG-0002FO-Fg for qemu-devel@nongnu.org; Mon, 10 Feb 2014 05:03:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCniB-0003ki-F2 for qemu-devel@nongnu.org; Mon, 10 Feb 2014 05:03:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCniB-0003kT-5c for qemu-devel@nongnu.org; Mon, 10 Feb 2014 05:03:35 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1AA3Xlk020758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Feb 2014 05:03:34 -0500 Date: Mon, 10 Feb 2014 10:03:30 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140210100329.GE3545@work-vm> References: <1391077232-14649-1-git-send-email-dgilbert@redhat.com> <1391077232-14649-2-git-send-email-dgilbert@redhat.com> <52F73F98.6070601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <52F73F98.6070601@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com * Laszlo Ersek (lersek@redhat.com) wrote: > On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > >=20 > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Alex Benn=E9e > > --- > > vl.c | 52 +++++++++++++++++++++++++++++++++++++++------------- > > 1 file changed, 39 insertions(+), 13 deletions(-) > >=20 > > diff --git a/vl.c b/vl.c > > index 7f4fe0d..5f993e4 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -531,6 +531,27 @@ static QemuOptsList qemu_msg_opts =3D { > > }, > > }; > > =20 > > +static QemuOptsList qemu_name_opts =3D { > > + .name =3D "name", > > + .implied_opt_name =3D "guest", > > + .merge_lists =3D true, > > + .head =3D QTAILQ_HEAD_INITIALIZER(qemu_name_opts.head), > > + .desc =3D { > > + { > > + .name =3D "guest", > > + .type =3D QEMU_OPT_STRING, > > + .help =3D "Sets the name of the guest.\n" > > + "This name will be displayed in the SDL window cap= tion.\n" > > + "The name will also be used for the VNC server", > > + }, { > > + .name =3D "process", > > + .type =3D QEMU_OPT_STRING, > > + .help =3D "Sets the name of the QEMU process, as shown in = top etc", > I have one question, but it doesn't block my R-b: >=20 > Did you test (and if so, how) the new .help text for "guest"? Because it > seems to be the only such text that has newline characters embedded. I > looked around the tree a bit, and it seems that the only way to get > these option texts is the "query-command-line-options" QMP command > (apparently not available via HMP). If that's the case, then the > embedded newlines could / should be dropped. But I don't really care > about those. I'd checked every piece of output I'd found, but hadn't found the query-command-line-options; I think you're right there are no other \n's in there - but also all the other .help texts are much briefer and less chatty; maybe I need to just chop them down to a minimum, I wonder if there is anywhere they're ever displayed to a human? Dave > Reviewed-by: Laszlo Ersek >=20 > Thanks > Laszlo >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK