From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include
Date: Mon, 10 Feb 2014 11:18:37 +0100 [thread overview]
Message-ID: <20140210101837.GB2832@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <20140210070044.GA15707@T430.nay.redhat.com>
Am 10.02.2014 um 08:00 hat Fam Zheng geschrieben:
> On Sun, 02/09 10:02, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > hw/sd/sdhci.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> > index 0906a1d..a0b90ba 100644
> > --- a/hw/sd/sdhci.c
> > +++ b/hw/sd/sdhci.c
> > @@ -26,7 +26,6 @@
> > #include "sysemu/blockdev.h"
> > #include "sysemu/dma.h"
> > #include "qemu/timer.h"
> > -#include "block/block_int.h"
> > #include "qemu/bitops.h"
> >
> > #include "sdhci.h"
> > --
> > 1.8.1.4
> >
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
>
> BTW it seems bitops.h is not used too, although I'm not 100% sure.
Not sure, you'd have to try it out.
The main reason for this removal is that it is the last user of
block_int.h in hw/
Kevin
next prev parent reply other threads:[~2014-02-10 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 9:02 [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include Kevin Wolf
2014-02-10 7:00 ` Fam Zheng
2014-02-10 10:18 ` Kevin Wolf [this message]
2014-02-10 16:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210101837.GB2832@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).