From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WCnyq-0000yJ-2i
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 05:20:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WCnyl-0008PS-0n
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 05:20:47 -0500
Date: Mon, 10 Feb 2014 11:20:34 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140210102034.GA15227@stefanha-thinkpad.brq.redhat.com>
References: <1391700611-32893-1-git-send-email-agraf@suse.de>
	<52F485C5.1020107@msgid.tls.msk.ru>
	<0C8B4C82-8DB7-4B5E-81F0-0C321856BB70@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0C8B4C82-8DB7-4B5E-81F0-0C321856BB70@suse.de>
Subject: Re: [Qemu-devel] [PATCH] net: Include iov.h in checksum.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Dmitry Fleytman <dmitry@daynix.com>, qemu-trivial <qemu-trivial@nongnu.org>, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@amazon.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote:
> 
> 
> > Am 07.02.2014 um 08:05 schrieb Michael Tokarev <mjt@tls.msk.ru>:
> > 
> > 06.02.2014 19:30, Alexander Graf wrote:
> >> The checksum calculation header exports a function that refers to struct
> >> iov which is defined in iov.h. Include the header so that the compiler
> >> knows what this struct is about.
> > 
> > Alternatively (and I sometimes prefer it this way), one can just
> > declare `struct iovec;' instead of including whole header, because
> > we don't actually use any definitions from there, and users of
> > checksum.h wont be including extra dependencies which they don't
> > use...  Like this:
> 
> Either way works for me :)

Yes, please take one of them via -trivial.

Stefan