From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45251)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WCwr6-0000Ni-7T
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 14:49:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WCwr0-0002PS-8N
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 14:49:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13652)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WCwqz-0002PL-Vb
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 14:49:18 -0500
Date: Mon, 10 Feb 2014 14:49:13 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140210144913.456c62ee@redhat.com>
In-Reply-To: <1390602475-19621-1-git-send-email-kroosec@gmail.com>
References: <1390602475-19621-1-git-send-email-kroosec@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: Add device_add type argument
	completion.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: qemu-devel@nongnu.org

On Fri, 24 Jan 2014 23:27:55 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Signed-off-by: Hani Benhabiles <kroosec@gmail.com>
> ---
>  monitor.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 845f608..cf91544 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4254,6 +4254,26 @@ static const char *next_arg_type(const char *typestr)
>      return (p != NULL ? ++p : typestr);
>  }
>  
> +static void device_add_completion(ReadLineState *rs, const char *str)
> +{
> +    GSList *list, *elt;
> +    size_t len;
> +    len = strlen(str);
> +    readline_set_completion_index(rs, len);
> +    list = elt = object_class_get_list(TYPE_DEVICE, false);
> +    while (elt) {
> +        const char *name;
> +        DeviceClass *dc = OBJECT_CLASS_CHECK(DeviceClass, elt->data,
> +                                             TYPE_DEVICE);
> +        name = object_class_get_name(OBJECT_CLASS(dc));
> +        if (!strncmp(name, str, len)) {
> +            readline_add_completion(rs, name);
> +        }
> +        elt = elt->next;
> +    }
> +    g_slist_free(list);
> +}
> +
>  static void monitor_find_completion_by_table(Monitor *mon,
>                                               const mon_cmd_t *cmd_table,
>                                               char **args,
> @@ -4317,6 +4337,11 @@ static void monitor_find_completion_by_table(Monitor *mon,
>              readline_set_completion_index(mon->rs, strlen(str));
>              bdrv_iterate(block_completion_it, &mbs);
>              break;
> +        case 'O':
> +            if (!strcmp(cmd->name, "device_add")) {
> +                device_add_completion(mon->rs, str);

This is nice, but it keeps printing auto-completion options even after
it has auto-completed. For example:

(qemu) device_add pcnet <TAB>

Will show all device names once again.

> +            }
> +            break;
>          case 's':
>          case 'S':
>              if (!strcmp(cmd->name, "sendkey")) {