From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCxL0-0004ah-MR for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:20:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCxKu-000445-NO for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:20:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCxKu-00043v-Dv for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:20:12 -0500 Date: Mon, 10 Feb 2014 15:16:56 -0500 From: Luiz Capitulino Message-ID: <20140210151656.74c32599@redhat.com> In-Reply-To: <1390859654-8549-1-git-send-email-kroosec@gmail.com> References: <1390859654-8549-1-git-send-email-kroosec@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] monitor: Add device_del argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: qemu-devel@nongnu.org On Mon, 27 Jan 2014 22:54:14 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Applied to the qmp branch, thanks. > --- > monitor.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/monitor.c b/monitor.c > index 80456fb..a7a589e 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4254,6 +4254,25 @@ static const char *next_arg_type(const char *typestr) > return (p != NULL ? ++p : typestr); > } > > +static void device_del_completion(ReadLineState *rs, BusState *bus, > + const char *str, size_t len) > +{ > + BusChild *kid; > + > + QTAILQ_FOREACH(kid, &bus->children, sibling) { > + DeviceState *dev = kid->child; > + BusState *dev_child; > + > + if (dev->id && !strncmp(str, dev->id, len)) { > + readline_add_completion(rs, dev->id); > + } > + > + QLIST_FOREACH(dev_child, &dev->child_bus, sibling) { > + device_del_completion(rs, dev_child, str, len); > + } > + } > +} > + > static void monitor_find_completion_by_table(Monitor *mon, > const mon_cmd_t *cmd_table, > char **args, > @@ -4330,6 +4349,10 @@ static void monitor_find_completion_by_table(Monitor *mon, > } else if (!strcmp(cmd->name, "help|?")) { > monitor_find_completion_by_table(mon, cmd_table, > &args[1], nb_args - 1); > + } else if (!strcmp(cmd->name, "device_del") && nb_args == 2) { > + size_t len = strlen(str); > + readline_set_completion_index(mon->rs, len); > + device_del_completion(mon->rs, sysbus_get_default(), str, len); > } > break; > default: