From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCyMo-0002bn-RH for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:26:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCyMi-0006VW-JG for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:26:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCyMi-0006VO-9e for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:26:08 -0500 Date: Mon, 10 Feb 2014 16:26:04 -0500 From: Luiz Capitulino Message-ID: <20140210162604.174dcbca@redhat.com> In-Reply-To: <20140210212302.GA3883@Inspiron-3521> References: <1390602475-19621-1-git-send-email-kroosec@gmail.com> <20140210144913.456c62ee@redhat.com> <20140210212302.GA3883@Inspiron-3521> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] monitor: Add device_add type argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: qemu-devel@nongnu.org On Mon, 10 Feb 2014 22:23:02 +0100 Hani Benhabiles wrote: > Hi Luiz, > > Thanks for taking a look at it. > > On Mon, Feb 10, 2014 at 02:49:13PM -0500, Luiz Capitulino wrote: > > On Fri, 24 Jan 2014 23:27:55 +0100 > > Hani Benhabiles wrote: > > > > > Signed-off-by: Hani Benhabiles > > > --- > > > monitor.c | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/monitor.c b/monitor.c > > > index 845f608..cf91544 100644 > > > --- a/monitor.c > > > +++ b/monitor.c > > > @@ -4254,6 +4254,26 @@ static const char *next_arg_type(const char *typestr) > > > return (p != NULL ? ++p : typestr); > > > } > > > > > > +static void device_add_completion(ReadLineState *rs, const char *str) > > > +{ > > > + GSList *list, *elt; > > > + size_t len; > > > + len = strlen(str); > > > + readline_set_completion_index(rs, len); > > > + list = elt = object_class_get_list(TYPE_DEVICE, false); > > > + while (elt) { > > > + const char *name; > > > + DeviceClass *dc = OBJECT_CLASS_CHECK(DeviceClass, elt->data, > > > + TYPE_DEVICE); > > > + name = object_class_get_name(OBJECT_CLASS(dc)); > > > + if (!strncmp(name, str, len)) { > > > + readline_add_completion(rs, name); > > > + } > > > + elt = elt->next; > > > + } > > > + g_slist_free(list); > > > +} > > > + > > > static void monitor_find_completion_by_table(Monitor *mon, > > > const mon_cmd_t *cmd_table, > > > char **args, > > > @@ -4317,6 +4337,11 @@ static void monitor_find_completion_by_table(Monitor *mon, > > > readline_set_completion_index(mon->rs, strlen(str)); > > > bdrv_iterate(block_completion_it, &mbs); > > > break; > > > + case 'O': > > > + if (!strcmp(cmd->name, "device_add")) { > > > + device_add_completion(mon->rs, str); > > > > This is nice, but it keeps printing auto-completion options even after > > it has auto-completed. For example: > > > > (qemu) device_add pcnet > > > > Will show all device names once again. > > > > > + } > > > + break; > > > case 's': > > > case 'S': > > > if (!strcmp(cmd->name, "sendkey")) { > > > > I fixed the issue in these patch series: > http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00891.html > > Could you please take a look at it ? It's in my queue, I should get to it. Eventually :)