From: Fam Zheng <famz@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/5] qemu-iotests: Add 080 for IO throttling
Date: Tue, 11 Feb 2014 14:39:53 +0800 [thread overview]
Message-ID: <20140211063953.GA12675@T430.nay.redhat.com> (raw)
In-Reply-To: <20140210123233.GD3088@irqsave.net>
On Mon, 02/10 13:32, Benoît Canet wrote:
> Le Friday 07 Feb 2014 à 18:43:33 (+0800), Fam Zheng a écrit :
> > + nsec_per_sec = 1000000000
> > +
> > + # With current interface we can't set burst to 0, they will be override
> > + # to bps / 10 and iops / 10. Setting to 1 workarounds this and gets to
> > + # a close effect as no burst, which is good enough for us
> > + limits['bps_max'] = 1
> > + limits['iops_max'] = 1
> Maybe the code should also set *rd_max = 1 and *wr_max= 1 to make the *_rd_* and
> *_wr_* tests more accurate.
The code doesn't allow setting bps_rd_max together with bps_max. I think
bps_max has enough effective on burst, so it's not strictly necessary.
Fam
prev parent reply other threads:[~2014-02-11 6:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:43 [Qemu-devel] [PATCH v2 0/5] qemu-iotests: Test case for IO throttling Fam Zheng
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 1/5] qemu-io: Account IO by aio_read and aio_write Fam Zheng
2014-02-10 11:49 ` Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 2/5] qtest: Add scripts/qtest/qtest.py Fam Zheng
2014-02-10 12:04 ` Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2014-02-10 12:11 ` Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 5/5] qemu-iotests: Add 080 for IO throttling Fam Zheng
2014-02-10 12:32 ` Benoît Canet
2014-02-11 6:39 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211063953.GA12675@T430.nay.redhat.com \
--to=famz@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).