From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD9GL-0000wZ-6i for qemu-devel@nongnu.org; Tue, 11 Feb 2014 04:04:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WD9GG-00089I-J9 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 04:04:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD9GG-00088K-Ah for qemu-devel@nongnu.org; Tue, 11 Feb 2014 04:04:12 -0500 Date: Tue, 11 Feb 2014 17:04:09 +0800 From: Fam Zheng Message-ID: <20140211090409.GE12675@T430.nay.redhat.com> References: <7e56d87efc34a3c8501e0654ad89afd65fde259e.1392102900.git.hutao@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e56d87efc34a3c8501e0654ad89afd65fde259e.1392102900.git.hutao@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Kevin Wolf , Stefan Hajnoczi , Peter Lieven , qemu-devel@nongnu.org On Tue, 02/11 15:07, Hu Tao wrote: > This patch adds a new option preallocation for raw format, and implements > full preallocation. > > Signed-off-by: Hu Tao > --- > block/raw-posix.c | 43 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 01fb41a..1961b74 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -1229,11 +1229,22 @@ static int raw_create(const char *filename, QEMUOptionParameter *options, > int fd; > int result = 0; > int64_t total_size = 0; > + PreallocMode prealloc = PREALLOC_MODE_OFF; > > /* Read out options */ > while (options && options->name) { > if (!strcmp(options->name, BLOCK_OPT_SIZE)) { > total_size = options->value.n & BDRV_SECTOR_MASK; > + } else if (!strcmp(options->name, BLOCK_OPT_PREALLOC)) { > + if (!options->value.s || !strcmp(options->value.s, "off")) { > + prealloc = PREALLOC_MODE_OFF; > + } else if (!strcmp(options->value.s, "full")) { > + prealloc = PREALLOC_MODE_FULL; > + } else { > + error_setg(errp, "Invalid preallocation mode: '%s'", > + options->value.s); > + return -EINVAL; > + } > } > options++; > } > @@ -1243,16 +1254,27 @@ static int raw_create(const char *filename, QEMUOptionParameter *options, > if (fd < 0) { > result = -errno; > error_setg_errno(errp, -result, "Could not create file"); > - } else { > - if (ftruncate(fd, total_size) != 0) { > - result = -errno; > - error_setg_errno(errp, -result, "Could not resize file"); > - } > - if (qemu_close(fd) != 0) { > - result = -errno; > - error_setg_errno(errp, -result, "Could not close the new file"); > + goto out; > + } > + if (ftruncate(fd, total_size) != 0) { > + result = -errno; > + error_setg_errno(errp, -result, "Could not resize file"); > + goto out_close; > + } > + if (prealloc == PREALLOC_MODE_FULL) { > + /* posix_fallocate() doesn't set errno. */ > + result = -posix_fallocate(fd, 0, total_size); > + if (result != 0) { > + error_setg_errno(errp, -result, > + "Could not preallocate data for the new file"); > } > } > +out_close: > + if (qemu_close(fd) != 0) { > + result = -errno; > + error_setg_errno(errp, -result, "Could not close the new file"); If errp is already set because ftruncate or posix_ftruncate failed, and qemu_close() fails too, the call to error_setg_errno() will abort on failing the assertion of (*errp == NULL). You could either embed the two failures in one error message, or pick the urgent one and drop the other. Thanks, Fam > + } > +out: > return result; > } > > @@ -1403,6 +1425,11 @@ static QEMUOptionParameter raw_create_options[] = { > .type = OPT_SIZE, > .help = "Virtual disk size" > }, > + { > + .name = BLOCK_OPT_PREALLOC, > + .type = OPT_STRING, > + .help = "Preallocation mode (allowed values: off, full)" > + }, > { NULL } > }; > > -- > 1.8.0 >