From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Alex Benn?e <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
mjt@tls.msk.ru, qemu-devel@nongnu.org, edgari@xilinx.com,
mkletzan@redhat.com
Subject: Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk
Date: Tue, 11 Feb 2014 12:41:41 +0000 [thread overview]
Message-ID: <20140211124140.GC2509@work-vm> (raw)
In-Reply-To: <87ioslhliu.fsf@linaro.org>
* Alex Benn?e (alex.bennee@linaro.org) wrote:
>
> Dr. David Alan Gilbert <dgilbert@redhat.com> writes:
>
> > * Peter Crosthwaite (peter.crosthwaite@xilinx.com) wrote:
> >> This was guarding against a full fifo rather than an empty fifo when
> >> popping. Fix.
> >>
> >> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> >> ---
> >
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > I think this brings it back to how it was on the old FIFO code.
>
> This does make me wonder why it was changed? Was there another crashing
> case it fixed?
The old serial code had it's own FIFO implementation, and that was
removed so that we had one less FIFO in the codebase; the problem
was that the old one in the serial code just returned 0 when empty,
the shared one aborts.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-02-11 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 6:49 [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check Peter Crosthwaite
2014-02-11 9:55 ` Dr. David Alan Gilbert
2014-02-11 12:38 ` [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk Alex Bennée
2014-02-11 12:41 ` Dr. David Alan Gilbert [this message]
2014-02-11 10:25 ` [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check Martin Kletzander
2014-02-11 10:29 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211124140.GC2509@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=edgari@xilinx.com \
--cc=mjt@tls.msk.ru \
--cc=mkletzan@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).