qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell
Date: Thu, 13 Feb 2014 09:44:03 +0800	[thread overview]
Message-ID: <20140213014403.GA28393@T430.nay.redhat.com> (raw)
In-Reply-To: <52FBBA18.8070104@redhat.com>

On Wed, 02/12 11:14, Eric Blake wrote:
> On 02/11/2014 08:05 PM, Fam Zheng wrote:
> > As another convinience to allow using commands that expect a dict as
> 
> You missed this, even though I pointed it out in v2:
> 
> s/convinience/convenience/

Oops, I'm sorry for that. Luiz, would you fix this when applying?

Thanks,
Fam

> 
> > argument, this patch adds support for foo.bar=value syntax, similar to
> > command line argument style:
> > 
> >   (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > 
> > ---
> 
> My python is weak, so take this with a grain of salt:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 

  reply	other threads:[~2014-02-13  1:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  3:05 [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell Fam Zheng
2014-02-12 18:14 ` Eric Blake
2014-02-13  1:44   ` Fam Zheng [this message]
2014-02-14  9:47 ` Stefan Hajnoczi
2014-02-27 15:35 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213014403.GA28393@T430.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).