From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg
Date: Thu, 13 Feb 2014 09:02:37 +0100 [thread overview]
Message-ID: <20140213080237.GA32343@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <3196de212da6d9fd5f93cce7d0ae276e8e1795b0.1392234236.git.jcody@redhat.com>
Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben:
> There are a handful of places in the block layer where a failure path
> has a valid -errno value, yet error_setg() is used. Those instances
> should instead use error_setg_errno(), to preserve as much error
> information as possible.
>
> This patch replaces those instances with error_setg_errno(), so that
> errno is passed up the stack in the error message.
>
> Reported-By: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2014-02-13 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 19:46 [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg Jeff Cody
2014-02-12 19:50 ` Eric Blake
2014-02-13 1:58 ` Fam Zheng
2014-02-13 8:02 ` Kevin Wolf [this message]
2014-02-14 15:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213080237.GA32343@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).