From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDrFy-0002fq-Nn for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDrFs-0008Si-Pv for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:02:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDrFs-0008SX-J5 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:02:44 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1D82fTx016597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Feb 2014 03:02:41 -0500 Date: Thu, 13 Feb 2014 09:02:37 +0100 From: Kevin Wolf Message-ID: <20140213080237.GA32343@dhcp-200-207.str.redhat.com> References: <3196de212da6d9fd5f93cce7d0ae276e8e1795b0.1392234236.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3196de212da6d9fd5f93cce7d0ae276e8e1795b0.1392234236.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: > There are a handful of places in the block layer where a failure path > has a valid -errno value, yet error_setg() is used. Those instances > should instead use error_setg_errno(), to preserve as much error > information as possible. > > This patch replaces those instances with error_setg_errno(), so that > errno is passed up the stack in the error message. > > Reported-By: Kevin Wolf > Signed-off-by: Jeff Cody Reviewed-by: Kevin Wolf