From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDruG-0004hq-RK for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:44:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDruB-0003lt-Pr for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:44:28 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:49900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDruB-0003ld-FN for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:44:23 -0500 Date: Thu, 13 Feb 2014 09:44:21 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140213084421.GA3119@irqsave.net> References: <1392256297-21782-2-git-send-email-benoit.canet@irqsave.net> <20140213083352.GD32343@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140213083352.GD32343@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , famz@redhat.com, jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com The Thursday 13 Feb 2014 =E0 09:33:52 (+0100), Kevin Wolf wrote : > Am 13.02.2014 um 02:51 hat Beno=EEt Canet geschrieben: > > Signed-off-by: Benoit Canet > > --- > > block.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > Should be [PATCH v3] in the subject line. >=20 > > diff --git a/block.c b/block.c > > index 70d7f35..d9553ba 100644 > > --- a/block.c > > +++ b/block.c > > @@ -5419,11 +5419,7 @@ bool bdrv_is_first_non_filter(BlockDriverState= *candidate) > > QTAILQ_FOREACH(bs, &bdrv_states, device_list) { > > bool perm; > > =20 > > - if (!bs->file) { > > - continue; > > - } > > - > > - perm =3D bdrv_recurse_is_first_non_filter(bs->file, candidat= e); > > + perm =3D bdrv_recurse_is_first_non_filter(bs, candidate); > > =20 > > /* candidate is the first non filter */ > > if (perm) { >=20 > So we're back to my patch, just with different author? I thought you > said something was broken with it? Yes it's your patch. My quorum command line had extra "file." in front of the quorum parameter= s. (the user error you mentioned) That's the reason I initially broke snapshot's because I was testing agai= nst something like bs->file thinking it was normal to get top bs in bs->file. And that's also the reason why I though your patch was broken. The quorum series also need a repost to get rid of the "file." of the com= mit comment. Best regards Beno=EEt >=20 > Kevin >=20