From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell
Date: Fri, 14 Feb 2014 10:47:55 +0100 [thread overview]
Message-ID: <20140214094755.GC6941@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1392174313-25921-1-git-send-email-famz@redhat.com>
On Wed, Feb 12, 2014 at 11:05:13AM +0800, Fam Zheng wrote:
> As another convinience to allow using commands that expect a dict as
> argument, this patch adds support for foo.bar=value syntax, similar to
> command line argument style:
>
> (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v3: Fix error message wording. (Eric)
> v2: Fix variable usage and improved error check and report.
>
> Applies on top of Stefan's patch
>
> [PATCH] QMP: allow JSON dict arguments in qmp-shell
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> scripts/qmp/qmp-shell | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2014-02-14 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 3:05 [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell Fam Zheng
2014-02-12 18:14 ` Eric Blake
2014-02-13 1:44 ` Fam Zheng
2014-02-14 9:47 ` Stefan Hajnoczi [this message]
2014-02-27 15:35 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214094755.GC6941@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).