From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFNO-0001dj-LP
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:48:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFNH-0005PY-Ew
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:48:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13370)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFNG-0005Of-Vz
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:47:59 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1E9lvWS021710
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 Feb 2014 04:47:57 -0500
Date: Fri, 14 Feb 2014 10:47:55 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140214094755.GC6941@stefanha-thinkpad.redhat.com>
References: <1392174313-25921-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1392174313-25921-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path
 arguments in qmp-shell
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Feb 12, 2014 at 11:05:13AM +0800, Fam Zheng wrote:
> As another convinience to allow using commands that expect a dict as
> argument, this patch adds support for foo.bar=value syntax, similar to
> command line argument style:
> 
>   (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v3: Fix error message wording. (Eric)
> v2: Fix variable usage and improved error check and report.
> 
> Applies on top of Stefan's patch
> 
>     [PATCH] QMP: allow JSON dict arguments in qmp-shell
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  scripts/qmp/qmp-shell | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>