From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEFad-0008IF-Qs for qemu-devel@nongnu.org; Fri, 14 Feb 2014 05:01:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEFaY-0005w7-Qx for qemu-devel@nongnu.org; Fri, 14 Feb 2014 05:01:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEFaY-0005w0-JG for qemu-devel@nongnu.org; Fri, 14 Feb 2014 05:01:42 -0500 Date: Fri, 14 Feb 2014 11:01:35 +0100 From: Kevin Wolf Message-ID: <20140214100135.GI32343@dhcp-200-207.str.redhat.com> References: <1392308553-9886-1-git-send-email-benoit.canet@irqsave.net> <1392308553-9886-2-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1392308553-9886-2-git-send-email-benoit.canet@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: qemu-devel@nongnu.org, Benoit Canet Am 13.02.2014 um 17:22 hat Beno=EEt Canet geschrieben: > As bdrv_open() documentation states: > "The reference to the QDict belongs to the block layer > * after the call (even on failure), so if the caller intends to reuse = the > * dictionary, it needs to use QINCREF() before calling bdrv_open." >=20 > the optional options dict will not be reused after bdrv_open() and shou= ld > belong to the block layer so remove the extra QDECREF(options). >=20 > Signed-off-by: Benoit Canet Ouch, yes. Sorry for not catching this in the review. Reviewed-by: Kevin Wolf