From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEHva-0007zl-9s for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:31:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEHvR-0003DI-Ta for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:31:34 -0500 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:37809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEHvR-0003DD-N3 for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:31:25 -0500 Received: by mail-we0-f172.google.com with SMTP id p61so8803608wes.3 for ; Fri, 14 Feb 2014 04:31:24 -0800 (PST) Date: Fri, 14 Feb 2014 13:31:22 +0100 From: Stefan Hajnoczi Message-ID: <20140214123122.GC17391@stefanha-thinkpad.redhat.com> References: <1391434310-9990-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391434310-9990-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] glib: move compat functions into glib-compat.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , qemu-devel@nongnu.org, Anthony Liguori On Mon, Feb 03, 2014 at 02:31:47PM +0100, Stefan Hajnoczi wrote: > glib has deprecated APIs like GStaticMutex, g_thread_create(), and others. In > QEMU support both old and new APIs since using deprecated APIs would flood us > with warnings but legacy distros must continue to build the QEMU source code. > > This patch series reduces ifdefs by moving glib compat functions into > glib-compat.h, where they can be reused. > > There are two strategies for compat functions: > > 1. Implement the new API using the deprecated API. This compat function is > used when building on a legacy host. Sometimes the API semantics are so > different that this option is not feasible. > > 2. Add a new wrapper API that maps to the deprecated API. The wrapper is not > marked deprecated so it works as a drop-in replacement but is implemented > using the new API where possible. > > Stefan Hajnoczi (3): > glib: move g_poll() replacement into glib-compat.h > glib: add g_thread_new() compat function > glib: add compat wrapper for GStaticMutex > > coroutine-gthread.c | 26 ++++++++++---------------- > include/glib-compat.h | 44 ++++++++++++++++++++++++++++++++++++++++++++ > include/qemu-common.h | 12 ------------ > trace/simple.c | 31 ++++++++++--------------------- > 4 files changed, 64 insertions(+), 49 deletions(-) Ping?