From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare
Date: Fri, 14 Feb 2014 13:38:52 +0100 [thread overview]
Message-ID: <20140214123852.GD17391@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <6811045539cc2d35ceff331326220aba2af9e670.1391541004.git.jcody@redhat.com>
On Tue, Feb 04, 2014 at 02:12:44PM -0500, Jeff Cody wrote:
> iSCSI currently does not need to do any actions to support the
> current usage of bdrv_reopen(). However, it is important to note
> a couple of things: 1.) A connection will not be re-established to
> an iSCSI target, and 2.) If iscsi_open() is changed to parse 'flags',
> then iscsi_reopen_prepare() may need to be more than a stub.
>
> In light of the above, this commit adds comments above both of the
> functions to bring attention to these facts.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> block/iscsi.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2014-02-14 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 19:12 [Qemu-devel] [PATCH] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare Jeff Cody
2014-02-14 12:38 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214123852.GD17391@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).