From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEI2p-0001Hj-6A for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:39:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEI2i-0005SO-GL for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:39:03 -0500 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:44287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEI2i-0005SG-AE for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:38:56 -0500 Received: by mail-we0-f179.google.com with SMTP id q58so8817091wes.10 for ; Fri, 14 Feb 2014 04:38:55 -0800 (PST) Date: Fri, 14 Feb 2014 13:38:52 +0100 From: Stefan Hajnoczi Message-ID: <20140214123852.GD17391@stefanha-thinkpad.redhat.com> References: <6811045539cc2d35ceff331326220aba2af9e670.1391541004.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6811045539cc2d35ceff331326220aba2af9e670.1391541004.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Feb 04, 2014 at 02:12:44PM -0500, Jeff Cody wrote: > iSCSI currently does not need to do any actions to support the > current usage of bdrv_reopen(). However, it is important to note > a couple of things: 1.) A connection will not be re-established to > an iSCSI target, and 2.) If iscsi_open() is changed to parse 'flags', > then iscsi_reopen_prepare() may need to be more than a stub. > > In light of the above, this commit adds comments above both of the > functions to bring attention to these facts. > > Signed-off-by: Jeff Cody > --- > block/iscsi.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan