From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJVe-0000xW-8m
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:13:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJVV-0005gQ-SZ
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:12:54 -0500
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:49029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJVV-0005gL-Lh
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:12:45 -0500
Received: by mail-we0-f169.google.com with SMTP id t61so8903316wes.0
	for <qemu-devel@nongnu.org>; Fri, 14 Feb 2014 06:12:44 -0800 (PST)
Date: Fri, 14 Feb 2014 15:12:41 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140214141241.GE17391@stefanha-thinkpad.redhat.com>
References: <cover.1391541706.git.jcody@redhat.com>
	<925f4c0a62291c070991d1b3e75a770de986a686.1391541706.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <925f4c0a62291c070991d1b3e75a770de986a686.1391541706.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements,
 state storage changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, bharata@linux.vnet.ibm.com

On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote:
> diff --git a/block/gluster.c b/block/gluster.c
> index a009b15..79af3fd 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -30,6 +30,8 @@ typedef struct GlusterAIOCB {
>  typedef struct BDRVGlusterState {
>      struct glfs *glfs;
>      struct glfs_fd *fd;
> +    int open_flags;

Is this field used?  I only see stores to this field but no loads.

Seems unnecessary since the block layer already provides us with QEMU
BDRV_* flags and qemu_gluster_parse_flags() can be used to produce POSIX
open(2) flags from them.