From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJe8-0004T0-Rf
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:21:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJe0-0000a5-F0
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:21:40 -0500
Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:48839)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEJe0-0000Zx-0s
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:21:32 -0500
Received: by mail-wg0-f48.google.com with SMTP id a1so430349wgh.15
	for <qemu-devel@nongnu.org>; Fri, 14 Feb 2014 06:21:31 -0800 (PST)
Date: Fri, 14 Feb 2014 15:21:28 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140214142128.GF17391@stefanha-thinkpad.redhat.com>
References: <cover.1391541706.git.jcody@redhat.com>
	<925f4c0a62291c070991d1b3e75a770de986a686.1391541706.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <925f4c0a62291c070991d1b3e75a770de986a686.1391541706.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements,
 state storage changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, bharata@linux.vnet.ibm.com

On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote:
> @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
>  
>      filename = qemu_opt_get(opts, "filename");
>  
> +    s->filename = g_strdup(filename);

It's not obvious to me that copying the filename is necessary.
block/raw-posix.c does this:

  raw_s->fd = qemu_open(state->bs->filename, raw_s->open_flags);

Why didn't you use bs->filename?

Stefan