From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers
Date: Fri, 14 Feb 2014 15:32:49 +0100 [thread overview]
Message-ID: <20140214143249.GG17391@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1391856067-16860-1-git-send-email-stefanha@redhat.com>
On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote:
> It is dangerous to include user headers before system headers since user
> macros can affect system headers.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/endianness-test.c | 2 +-
> tests/fw_cfg-test.c | 7 +++----
> tests/i440fx-test.c | 11 +++++------
> tests/m48t59-test.c | 3 ++-
> tests/qom-test.c | 3 ++-
> tests/rtc-test.c | 5 +++--
> tests/tmp105-test.c | 5 +++--
> 7 files changed, 19 insertions(+), 17 deletions(-)
Ping?
Is anyone willing to be qtest maintainer, i.e. you understand qtest, can
review patches, and will send pull requests?
next prev parent reply other threads:[~2014-02-14 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 10:41 [Qemu-devel] [PATCH] qtest: include system headers before user headers Stefan Hajnoczi
2014-02-14 14:32 ` Stefan Hajnoczi [this message]
2014-02-14 14:42 ` Andreas Färber
2014-02-14 15:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214143249.GG17391@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).