From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations
Date: Fri, 14 Feb 2014 15:38:51 +0100 [thread overview]
Message-ID: <20140214143851.GI17391@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1391936581-8382-1-git-send-email-ehabkost@redhat.com>
On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote:
> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> CODING_STYLE | 7 +++++++
> 1 file changed, 7 insertions(+)
I think C99 mixed declarations and code are a good thing. It's easier
to read code when the local variable type is alongside the
initialization.
I'll try to avoid mixed declarations and code if the others feel this
rule is worthwhile.
Stefan
next prev parent reply other threads:[~2014-02-14 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 9:03 [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations Eduardo Habkost
2014-02-10 1:33 ` Fam Zheng
2014-02-10 6:09 ` Stefan Weil
2014-02-10 8:16 ` Eduardo Habkost
2014-02-14 14:38 ` Stefan Hajnoczi [this message]
2014-02-19 19:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214143851.GI17391@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).