From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJux-0003pU-Oh for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:39:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEJup-0006SG-Al for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:39:03 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:45798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJup-0006S5-3U for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:38:55 -0500 Received: by mail-wi0-f173.google.com with SMTP id hn9so531161wib.12 for ; Fri, 14 Feb 2014 06:38:54 -0800 (PST) Date: Fri, 14 Feb 2014 15:38:51 +0100 From: Stefan Hajnoczi Message-ID: <20140214143851.GI17391@stefanha-thinkpad.redhat.com> References: <1391936581-8382-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391936581-8382-1-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Paolo Bonzini , qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > --- > CODING_STYLE | 7 +++++++ > 1 file changed, 7 insertions(+) I think C99 mixed declarations and code are a good thing. It's easier to read code when the local variable type is alongside the initialization. I'll try to avoid mixed declarations and code if the others feel this rule is worthwhile. Stefan