Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

[Stefan Hajnoczi <stefanha@gmail.com>]

On Wed, Feb 12, 2014 at 02:46:24PM -0500, Jeff Cody wrote:
> There are a handful of places in the block layer where a failure path
> has a valid -errno value, yet error_setg() is used.  Those instances
> should instead use error_setg_errno(), to preserve as much error
> information as possible.
> 
> This patch replaces those instances with error_setg_errno(), so that
> errno is passed up the stack in the error message.
> 
> Reported-By: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/mirror.c         | 13 +++++++++----
>  block/qcow2-snapshot.c |  8 +++++---
>  block/vmdk.c           |  6 +++---
>  3 files changed, 17 insertions(+), 10 deletions(-)

You are a lucky man, getting so many Reviewed-by: lines.  I think this
is a record!

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan