From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WELgA-0008Pk-Un for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:32:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WELg2-00021K-9U for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:31:54 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:34977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WELg2-00021E-0M for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:31:46 -0500 Received: by mail-wg0-f42.google.com with SMTP id k14so513992wgh.1 for ; Fri, 14 Feb 2014 08:31:45 -0800 (PST) Date: Fri, 14 Feb 2014 17:31:42 +0100 From: Stefan Hajnoczi Message-ID: <20140214163142.GG23572@stefanha-thinkpad.redhat.com> References: <1392138233-26407-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392138233-26407-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/20] Improve bdrv_open error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org On Tue, Feb 11, 2014 at 06:03:33PM +0100, Paolo Bonzini wrote: > Most of the block drivers are not using the Error** argument to > bdrv_open, and instead just printing errors to stderr. This series > improves that, using Error** instead of abusing errno numbers too. > > The only hurdle (caught by qemu-iotests, too) is VMDK, where we > currently parse a file first as image, and second as a descriptor. > This makes it hard to pick a good error message, because you do not > know which attempt gave the most reasonable error message. For > this reason patches 15-17 modify this approach and push up the > detection of vmdk image file magic numbers. > > Apart from this, and from a segfault fixed by patch 7, the series > consists of mostly trivial patches. > > Paolo > > Paolo Bonzini (20): > nbd: produce a better error if neither host nor port is passed > nbd: correctly propagate errors > nbd: inline tcp_socket_incoming_spec into sole caller > nbd: move socket wrappers to qemu-nbd > iscsi: fix indentation > iscsi: correctly propagate errors in iscsi_open > gluster: default scheme to gluster:// and host to localhost. > gluster: correctly propagate errors > cow: correctly propagate errors > curl: correctly propagate errors > qcow: correctly propagate errors > qed: correctly propagate errors > vhdx: correctly propagate errors > vvfat: correctly propagate errors > vmdk: extract vmdk_read_desc > vmdk: push vmdk_read_desc up to caller > vmdk: do not try opening a file as both image and descriptor > vmdk: correctly propagate errors > block: do not abuse EMEDIUMTYPE > vdi: say why an image is bad > > block/bochs.c | 3 +- > block/cow.c | 15 ++--- > block/curl.c | 13 ++--- > block/gluster.c | 28 ++++----- > block/iscsi.c | 141 +++++++++++++++++++++++---------------------- > block/nbd.c | 43 +++++++------- > block/parallels.c | 3 +- > block/qcow.c | 19 +++--- > block/qcow2.c | 2 +- > block/qed.c | 19 +++--- > block/vdi.c | 29 ++++++---- > block/vhdx.c | 21 +++---- > block/vmdk.c | 121 ++++++++++++++++++++++++-------------- > block/vpc.c | 3 +- > block/vvfat.c | 9 +-- > include/block/nbd.h | 6 -- > nbd.c | 66 --------------------- > qemu-nbd.c | 52 +++++++++++++++++ > tests/qemu-iotests/059.out | 6 +- > 19 files changed, 302 insertions(+), 297 deletions(-) Looks good except for the memory leak that I commented on.