From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WErXl-0005b5-W4
	for qemu-devel@nongnu.org; Sat, 15 Feb 2014 21:33:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WErXd-0000pc-30
	for qemu-devel@nongnu.org; Sat, 15 Feb 2014 21:33:21 -0500
Received: from e38.co.us.ibm.com ([32.97.110.159]:50049)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WErXc-0000oQ-Rl
	for qemu-devel@nongnu.org; Sat, 15 Feb 2014 21:33:13 -0500
Received: from /spool/local
	by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Sat, 15 Feb 2014 19:33:11 -0700
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <5231C6FC.3060506@gmail.com>
References: <5231C6FC.3060506@gmail.com>
Message-ID: <20140216023304.1350.73103@loki>
Date: Sat, 15 Feb 2014 20:33:04 -0600
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak
	InetSocketAddress
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank <frank.yangjie@gmail.com>, qemu-stable@nongnu.org
Cc: Isaku Yamahata <yamahata@private.email.ne.jp>, Michael R Hines <mrhines@us.ibm.com>, lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org

Quoting Frank (2013-09-12 08:51:56)
> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu=
_rdma_data_init().
> =

> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
> From: Frank Yang <frank.yangjie@gmail.com>
> Date: Thu, 12 Sep 2013 21:37:56 +0800
> Subject: [PATCH] rdma: memory leak InetSocketAddress
> =

> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>

Ping, looking to pull this in for 1.7.1

> ---
>  migration-rdma.c | 1 +
>  1 file changed, 1 insertion(+)
> =

> diff --git a/migration-rdma.c b/migration-rdma.c
> index 05a155b..bcbe2d2 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_p=
ort, Error **errp)
>          }
>      }
> =

> +    qapi_free_InetSocketAddress(addr);
>      return rdma;
>  }
> =

> -- =

> 1.8.3.msysgit.0
> =

> -- =

> Frank