* [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress
@ 2013-09-12 13:51 Frank
2013-09-24 17:53 ` Michael R. Hines
2014-02-16 2:33 ` Michael Roth
0 siblings, 2 replies; 4+ messages in thread
From: Frank @ 2013-09-12 13:51 UTC (permalink / raw)
To: qemu-stable; +Cc: Isaku Yamahata, lilei, qemu-devel, Michael R Hines
It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
From: Frank Yang <frank.yangjie@gmail.com>
Date: Thu, 12 Sep 2013 21:37:56 +0800
Subject: [PATCH] rdma: memory leak InetSocketAddress
Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
---
migration-rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index 05a155b..bcbe2d2 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
}
}
+ qapi_free_InetSocketAddress(addr);
return rdma;
}
--
1.8.3.msysgit.0
--
Frank
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress
2013-09-12 13:51 [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress Frank
@ 2013-09-24 17:53 ` Michael R. Hines
2014-02-16 2:33 ` Michael Roth
1 sibling, 0 replies; 4+ messages in thread
From: Michael R. Hines @ 2013-09-24 17:53 UTC (permalink / raw)
To: Frank; +Cc: Isaku Yamahata, qemu-devel, Michael R Hines, qemu-stable, lilei
On 09/12/2013 09:51 AM, Frank wrote:
> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>
> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
> From: Frank Yang <frank.yangjie@gmail.com>
> Date: Thu, 12 Sep 2013 21:37:56 +0800
> Subject: [PATCH] rdma: memory leak InetSocketAddress
>
> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> ---
> migration-rdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index 05a155b..bcbe2d2 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
> }
> }
>
> + qapi_free_InetSocketAddress(addr);
> return rdma;
> }
>
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress
2013-09-12 13:51 [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress Frank
2013-09-24 17:53 ` Michael R. Hines
@ 2014-02-16 2:33 ` Michael Roth
2014-02-18 2:13 ` Michael R. Hines
1 sibling, 1 reply; 4+ messages in thread
From: Michael Roth @ 2014-02-16 2:33 UTC (permalink / raw)
To: Frank, qemu-stable; +Cc: Isaku Yamahata, Michael R Hines, lilei, qemu-devel
Quoting Frank (2013-09-12 08:51:56)
> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>
> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
> From: Frank Yang <frank.yangjie@gmail.com>
> Date: Thu, 12 Sep 2013 21:37:56 +0800
> Subject: [PATCH] rdma: memory leak InetSocketAddress
>
> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
Ping, looking to pull this in for 1.7.1
> ---
> migration-rdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index 05a155b..bcbe2d2 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
> }
> }
>
> + qapi_free_InetSocketAddress(addr);
> return rdma;
> }
>
> --
> 1.8.3.msysgit.0
>
> --
> Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress
2014-02-16 2:33 ` Michael Roth
@ 2014-02-18 2:13 ` Michael R. Hines
0 siblings, 0 replies; 4+ messages in thread
From: Michael R. Hines @ 2014-02-18 2:13 UTC (permalink / raw)
To: Michael Roth, Frank, qemu-stable
Cc: Isaku Yamahata, qemu-devel, Michael R Hines, lilei
On 02/16/2014 10:33 AM, Michael Roth wrote:
> Quoting Frank (2013-09-12 08:51:56)
>> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>>
>> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
>> From: Frank Yang <frank.yangjie@gmail.com>
>> Date: Thu, 12 Sep 2013 21:37:56 +0800
>> Subject: [PATCH] rdma: memory leak InetSocketAddress
>>
>> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> Ping, looking to pull this in for 1.7.1
Actually, this fix is not fully correct. Let me re-send.
- Michael
>> ---
>> migration-rdma.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/migration-rdma.c b/migration-rdma.c
>> index 05a155b..bcbe2d2 100644
>> --- a/migration-rdma.c
>> +++ b/migration-rdma.c
>> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
>> }
>> }
>>
>> + qapi_free_InetSocketAddress(addr);
>> return rdma;
>> }
>>
>> --
>> 1.8.3.msysgit.0
>>
>> --
>> Frank
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-18 2:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 13:51 [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress Frank
2013-09-24 17:53 ` Michael R. Hines
2014-02-16 2:33 ` Michael Roth
2014-02-18 2:13 ` Michael R. Hines
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).